Fix more typos in comments and docs#9404
Fix more typos in comments and docs#9404BennyWaitWhat wants to merge 2 commits intowarpdotdev:masterfrom
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR corrects spelling and grammar in comments and Markdown documentation only. The reviewed diff does not change executable logic, and the supplemental security pass found no security-impacting changes.
Concerns
- One changed doc-comment line still has an adjacent grammar issue.
Verdict
Found: 0 critical, 0 important, 1 suggestion
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
…9409) ## Description Renames a misspelled identifier (`delimeter` -> `delimiter`) across two modules. Pure rename: 2 files, +9/-9 lines, no behavioral change. **`app/src/env_vars/mod.rs`** - 6 changes: - `pub fn export_variables(&self, delimeter: &str, ...)` -> `delimiter` (parameter name) - Internal call site - Private `serialize_variables_internal(..., delimeter: &str, ...)` parameter - Three doc comments referencing the parameter **`app/src/external_secrets/mod.rs`** - 3 changes: - `static ref WARP_SECRET_DELIMETER` -> `WARP_SECRET_DELIMITER` (the constant *identifier*) - Two usages of the constant ### What is intentionally preserved The **string literal value** `"/warp-secret-delimeter/"` on line 22 is **kept as-is**. It is the runtime separator embedded in the `lpass --format=%an{}%ai` command and split back out of lpass's output (`line.split(*WARP_SECRET_DELIMITER)`). Changing the value would mean output emitted with one delimiter is parsed with another, breaking LastPass secret enumeration. Only the Rust identifier name is corrected; the on-the-wire token is unchanged. ### Caller analysis All three external call sites of `export_variables` (in `drive/index.rs`, `drive/export.rs`, `terminal/input.rs`) use positional arguments. Rust does not have named arguments, so the parameter rename is invisible to callers and breaks nothing. ### Related The comment `// Used as a delimeter to separate metadata` on line 20 of `external_secrets/mod.rs` is deliberately left for PR #9404 (the round-3 typo bundle), which already includes that fix. Different lines, no conflict. ## Testing Pure identifier rename; no logic touched. The string-literal preservation note above is the only correctness-relevant detail. ## Agent Mode - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode Co-authored-by: BennyWaitWhat <BennyWaitWhat@users.noreply.github.com>
Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
|
I'm checking this implementation PR for association with a likely matching ready issue. Powered by Oz |
|
@BennyWaitWhat Thanks for the PR! I'm gonna close this out since it's gone a bit stale. You're welcome to open another one or take a crack at one of the bugs marked |
Description
A third batch of unambiguous spelling and grammar typos in comments and Markdown docs. 18 files, +26/-26 lines, 29 individual typo corrections. All changes are inside
//or///comments or Markdown text; no functional code is touched.Categories:
propogate/propogates/propogation/propgate->propagate/ etc. (most common, 8+ instances acrossterminal/view.rs,tips/tip_view.rs,resource_center/main_page.rs,server/sync_queue.rs,integration/tests/common/mod.rs)reponder->responder(intip_view.rs,main_page.rs,code_review/mod.rs)accomodate->accommodate,enviornment->environment,intialize->initialize,hierachy->hierarchy,paramter->parameter,delimeter->delimiter(comment only; theWARP_SECRET_DELIMETERconstant and string literal on the next line are intentionally left untouched - they're part of an on-disk data format)appearence->appearance,precicely->precisely,handlign->handling,implmentation->implementation,throughought->throughout,comands->commandslocal_command_executor.rs:176had two typos in one line (then->the,enviornment->environment)An unique reference->A unique reference,an user input->a user input(both nouns start with a /j/ sound and take "a")Propogate->PropagateSkipped intentionally:
WARP_SECRET_DELIMETERconstant name and/warp-secret-delimeter/string literal inexternal_secrets/mod.rs:22(data format, separate refactor concern).delimeterparameter name and call sites inenv_vars/mod.rs(code-identifier rename, also a separate refactor).Testing
Comment / docs only; no test impact.
Agent Mode